[Security] Fix for potential XSS vulnerability #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tompave any chance of this getting merged? |
tompave
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Thank you for the PR, and apologies for the long wait.
This LGTM. 👍
I've been hesitant to take phoenix_html as a dependency, but copying here the useful functions is acceptable.
I need some time to test it manually before merging it. I'll try to get it done next week.
For what it's worth, we've been running a fork with this change for the past 4-5 months now and everything seems good. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escapes HTML and URLs everywhere.
Fixes #28