Stop the iterator for empty responses and do not process ERROR responses #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 92.53% 92.77% +0.24%
==========================================
Files 14 14
Lines 898 914 +16
==========================================
+ Hits 831 848 +17
+ Misses 67 66 -1
Continue to review full report at Codecov.
|
olitheolix
force-pushed
the
oli-k8s-errors
branch
2 times, most recently
from
befcc02
to
d956bc4
Compare
olitheolix
force-pushed
the
oli-k8s-errors
branch
from
d956bc4
to
871e42a
Compare
|
In case you accept this PR, can you please release a new version on PyPI? |
tomplus
reviewed
Jun 20, 2018
| cnt = 0 | ||
| async for _ in watch.stream(fake_api.get_namespaces): | ||
| cnt += 1 | ||
| assert cnt == len(side_effects) |
There was a problem hiding this comment.
self.assertEqual will be better here, it produces more meaningful errors.
| } | ||
|
|
||
| ret = Watch().unmarshal_event(json.dumps(k8s_err), None) | ||
| assert ret['type'] == k8s_err['type'] |
|
Latest release 1.0.0a4 has these changes, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two problems I encountered:
StopIterationfor empty K8s responses (eg when the timeout expires).