[fix] support refreshing exec api credentials #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomplus
reviewed
May 22, 2023
harryharpel
force-pushed
the
fix/refresh-exec-based-api-credentials
branch
from
66349ac
to
2891dc3
Compare
|
I have submitted changes in response to the previous feedback - please let me know if any additional changes are required to move this forward. |
tomplus
requested changes
Jun 16, 2023
harryharpel
force-pushed
the
fix/refresh-exec-based-api-credentials
branch
from
2891dc3
to
d2ad704
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 24.66% 24.68% +0.01%
==========================================
Files 736 736
Lines 99024 99045 +21
==========================================
+ Hits 24429 24449 +20
- Misses 74595 74596 +1
☔ View full report in Codecov by Sentry. |
harryharpel
force-pushed
the
fix/refresh-exec-based-api-credentials
branch
from
d2ad704
to
6f909ca
Compare
harryharpel
force-pushed
the
fix/refresh-exec-based-api-credentials
branch
from
6f909ca
to
8461f34
Compare
tomplus
approved these changes
Aug 4, 2023
|
Thank you for your maintenance work in this repo @tomplus and @harryharpel!! ❤️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257. This PR is based heavily on kubernetes-client/python-base#250. It also includes the fix made here to the non-asyncio library.
This change has been tested in multiple services that rely on a long running client that was previously failing due to expiring credentials.