test/type_test.ts: Fix import path #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Dec 19, 2019
test/type_test.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import ArSyncModel from './generated_typed_files/ArSyncModel' | |||
| import { useArSyncModel, useArSyncFetch } from './generated_typed_files/hooks' | |||
| import ActionCableAdapter from '../src/core/ActionCableAdapter' | |||
| import ActionCableAdapter from '../src/core/ActioncableAdapter' | |||
There was a problem hiding this comment.
あっ...
あ、でもこれ、ファイル名の方を変えたい importの名前と揃えたい
import XxX from '../a/b/XxX' か import XXX from '../a/b/XXX'
There was a problem hiding this comment.
あー、確かに名前揃えたい
なんかすでに導入されてるプロジェクトだとファイル名のリネームすると若干だるそうかなと思ってテストの中だけ直す、に倒してしまった。
importしてる名前直すよりファイル名直す方が楽そうなので、ファイル名リネームしてみようかな
There was a problem hiding this comment.
よく見たらREADMEのほうではパスActionCableAdapterだったのでそっちにあわせます
There was a problem hiding this comment.
ありがとう、脳内ではずっとActionCableAdapterのつもりだったから...
あと actioncableのdocumentでもActionCableになってるからAdapterも名前合わせた方がいいはず
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.