Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search_people does not work properly #59

Closed
amerkay opened this issue Sep 6, 2019 · 2 comments
Closed

search_people does not work properly #59

amerkay opened this issue Sep 6, 2019 · 2 comments
Labels
bug Something isn't working and has been confirmed by a core contributor

Comments

@amerkay
Copy link

amerkay commented Sep 6, 2019

I found the bug referenced here.

Change L82, adding safe="()," to exclude problematic characters:

res = self._fetch(
    "/search/blended?{}".format(urlencode(default_params, safe="(),")),
    headers={"accept": "application/vnd.linkedin.normalized+json+2.1"},
)

Great work on this library! :)
@tomquirk
Copy link
Owner

tomquirk commented Sep 8, 2019

awesome, thanks for finding this @amerkay ! Happy to accept a PR for it if you like

@tomquirk tomquirk added the bug Something isn't working and has been confirmed by a core contributor label Sep 8, 2019
amerkay pushed a commit to amerkay/linkedin-api that referenced this issue Sep 8, 2019
search_people updates:
0d0f335 
Bug fix (tomquirk#59)
Added title search field
@amerkay amerkay mentioned this issue Sep 8, 2019
Merged
@amerkay
Copy link
Author

amerkay commented Sep 8, 2019

awesome, thanks for finding this @amerkay ! Happy to accept a PR for it if you like

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working and has been confirmed by a core contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amerkay @tomquirk