api.listen depreciated in favour of api.listenMqtt #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomquirk Is there anything stopping this being merged? Messer is basically unusable atm |
tomquirk
requested changes
Jun 1, 2020
There was a problem hiding this comment.
@ethan-ou thanks for this fix. listen is certainly not deprecated by the looks of their docs and the issue you linked to, however it is definitely broken, and listenMqtt appears to work. Let's merge your fix!! I just requested 1 change. Ping me again when you resolve and I will merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like recently the Facebook API changed to use a different messaging protocol called MQTT. The facebook-chat-api library updated to include this change by depreciating
api.listenin favour ofapi.listenMqtt. According to their docs, it's mostly a drop-in replacement.More on the API change can be found in the docs as well as in in issue #763.
This pull request also solves issue #137 in the Messer repo where new messages were not being received after login to Messer.