Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better structured project #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Better structured project #19

wants to merge 3 commits into from

Conversation

tomrf1
Copy link
Owner

@tomrf1 tomrf1 commented Jan 9, 2023

No description provided.

joelochlann
joelochlann reviewed Jan 9, 2023
View reviewed changes
corporate-connections/app/models/CompaniesHouseModels.scala
case class CompanyLink(company: String)
case class Appointment(officer_role: String, links: CompanyLink)
case class AppointedTo(company_name: String, company_number: String, company_status: String)
case class Appointment(officer_role: String, appointed_to: AppointedTo)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much more comprehensible now that we're using the more descriptive bit of the API

tomrf1 and others added 2 commits January 10, 2023 08:24
@tomrf1 @joelochlann
Update corporate-connections/conf/routes
5a403e8 
Co-authored-by: Joseph Smith <joseph.lochlann@gmail.com>
@tomrf1
companyNumber
72098cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelochlann joelochlann joelochlann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomrf1 @joelochlann