Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Find in single active file #26

Open
rkpatel33 opened this issue Feb 25, 2023 · 6 comments
Open

Suggestion: Find in single active file #26

rkpatel33 opened this issue Feb 25, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@rkpatel33
Copy link

I wondering if this was considered and not implemented for any reason? It would be a nice addition and make this have the same features as the FZF plugin available for Neovim, which has a buffer search mode.

(Again, this is a game changer for me and making me come back to VsCode from Nvim.)

@tomrijndorp
Copy link
Owner

I'm not sure what this means, it sounds like you're describing "search text", that is, Ctrl+F so clearly I must be misunderstanding something :) Do you have a reference that shows me what the feature is about? I tried searching but all the search terms are quite generic so if you can pass me a link I'd be sure we're talking about the same thing. Thanks!

@rkpatel33
Copy link
Author

You are right, ctrl-f will do this, but the benefit is of this is you get the list of all hits in a single file, as well as the code preview for each hit.

For example, here is Neovim FZF's "buffer search", which is what I am talking about. It's a nice UX.

image

@tomrijndorp
Copy link
Owner

Ah I see, thanks for the explanation! I don't have a ton of time to work on the extension right now, but I'm going to leave this ticket open as a nice to have and might be able to give this a try later. Thanks for the suggestion!

@tomrijndorp tomrijndorp added the enhancement New feature or request label Feb 28, 2023
@wroyca
Copy link

wroyca commented Feb 28, 2023

I second this, fantastic extension, I would love to have fzf in the current active file too, I was surprised to find out it wasn't already possible :)

@rkpatel33
Copy link
Author

If I have some time I will make an attempt at making the adjustment in a PR.

@sahellebusch
Copy link

This feature would be awesome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants