Add handlebars templating #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drjonnicholson thanks for taking the time to create this pr! Give me a few days to review it and hopefully we can get it merged in soon :) |
|
No rush @tomrule007 - any changes let me know, happy to update |
|
Hey @tomrule007, any thoughts / feedback? |
|
@drjonnicholson thanks for the contribution! I updated the Readme giving you credit for the template engine change and also published the new version. https://www.npmjs.com/package/bookmarklet-webpack-plugin/v/1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, starting to look at Bookmarklets for something and found your plugin. Thought I'd have a go at adding the template support mentioned. This PR:
Let me know what you think