Add firewall support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2022 21:29
tomsiewert
requested changes
Aug 12, 2022
src/main/java/me/tomsdevsn/hetznercloud/objects/general/FWApplicationTarget.java
Outdated
Show resolved
Hide resolved
|
It would be cool if you can add your change in // edit Okay I just saw that you are not on latest master. I'll approve the MR and add the changelog afterwards. |
added 2 commits
August 12, 2022 15:23
tomsiewert
approved these changes
Aug 12, 2022
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added firewall support as noted in #38, but mostly ignored tests