This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
feat: improve template based on internal review #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinm82
requested review from
askalski85,
Anatolii,
eugene-davis and
maikelvdh
maikelvdh
reviewed
Jul 31, 2019
martinm82
force-pushed
the
feature/template-improvements
branch
from
f056c91
to
d9c2794
Compare
eugene-davis
previously approved these changes
Aug 1, 2019
maikelvdh
previously approved these changes
Aug 1, 2019
martinm82
force-pushed
the
feature/template-improvements
branch
from
2be4b76
to
de51c6b
Compare
martinm82
changed the title
eugene-davis
reviewed
Aug 2, 2019
eugene-davis
previously approved these changes
Aug 2, 2019
eugene-davis
approved these changes
Aug 2, 2019
maikelvdh
approved these changes
Aug 2, 2019
askalski85
reviewed
Aug 2, 2019
| @@ -24,4 +24,4 @@ FROM $PYTHON_BASE | |||
| COPY --from=deploy_builder /opt/venv /opt/venv | |||
|
|
|||
| ENV PATH="/opt/venv/bin:$PATH" | |||
| ENTRYPOINT [""] | |||
| ENTRYPOINT ["{{ cookiecutter.project_name }}"] | |||
There was a problem hiding this comment.
name is slug? my-tool or my_tool ?
There was a problem hiding this comment.
slug=my_tool
project_name=my-tool
askalski85
reviewed
Aug 2, 2019
| @@ -52,12 +52,14 @@ setup: setup-checks ## install dev requirements | |||
| virtualenv --python=$(PYTHONVERSION) $(PYTHONENV) | |||
| $(ENVPIP) install -r requirements_dev.txt | |||
|
|
|||
| clean-all: clean | |||
There was a problem hiding this comment.
I think clean should always be clean all.
There was a problem hiding this comment.
Can't be because otherwise some commands will fail due to missing virtualenv (eg. dist target)
askalski85
approved these changes
Aug 2, 2019
pbomta
approved these changes
Aug 2, 2019
| "use_spellcheck": "y", | ||
| "use_spellcheck": "n", | ||
|
|
||
| "use_tox": "n", |
There was a problem hiding this comment.
Nope, it is still an experimental feature (same as Makefile)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various changes/improvements which are: