fix: GitHub releases and tags are now consistent (#5)

tomtom-international · May 17, 2022 · 91ec9ed · 91ec9ed
1 parent dfaa65d
commit 91ec9ed
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 ### Changed
+- GitHub Releases and associated tags are now both prefixed with `v` (i.e. `v1.0.0` iso `1.0.0`)
+
+## [1.0.1] - 2022-05-04
+### Changed
 - Updated README.md to be compatible with PyPi
 
 ## [1.0.0] - 2022-05-04

diff --git a/changelogmanager/github.py b/changelogmanager/github.py
@@ -140,13 +140,13 @@ def generate_release_notes(release: Mapping):
             )
             return body
 
-        version = changelog.suggest_future_version()
+        version = f"v{changelog.suggest_future_version()}"
         self.__github_request(
             method=HttpMethods.POST,
             api="releases",
             data={
-                "tag_name": str(version),
-                "name": f"Release v{version}",
+                "tag_name": version,
+                "name": f"Release {version}",
                 "draft": draft,
                 "body": generate_release_notes(changelog.get(UNRELEASED_ENTRY)),
             },