Fix: Inconsistent breakpoints #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @frzsombor - thanks for the PR! This would change the breakpoint for all 600,000+ websites currently using GP. We do our best not to allow updates to affect the frontend of our user's websites. It's likely that there are many people who like/depend on the current breakpoint to stay where it's at. As for bringing it closer to GenerateBlocks, we're currently working on GB2 where you will be able to choose your own breakpoints. This means you could change them to match GP. You will also be able build all aspects of your GP website in GB, so the inconsistency should be a non-problem in the near future. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #613