Skip to content

Commit

Permalink
Update the docs for BaseFilter to mention that the filter is _not_ un…
Browse files Browse the repository at this point in the history
…installed on Drop (#584)

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
  • Loading branch information
marmistrz and tomusdrw committed Jan 18, 2022
1 parent 83b4490 commit 033ac37
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/api/eth_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,10 @@ impl FilterInterface for PendingTransactionsFilter {
}

/// Base filter handle.
/// Uninstall filter on drop.
/// Allows to poll the filter.
///
/// Note: because Rust currently doesn't support async drop, the filter has to be uninstalled manually.
/// See [https://github.com/tomusdrw/rust-web3/issues/583](this tracking issue).
pub struct BaseFilter<T: Transport, I> {
// TODO [ToDr] Workaround for ganache returning 0x03 instead of 0x3
id: String,
Expand Down

0 comments on commit 033ac37

Please sign in to comment.