Fail deploy on failed status #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying a contract is successful only if the `status` field of the receipt is `0x1`. Before, the deployment was considered successful if the contract address was present. Fixes tomusdrw#241
geigerzaehler
force-pushed
the
fail-deploy-on-status
branch
from
76e720e
to
18618a1
Compare
tomusdrw
requested changes
Jul 30, 2019
src/contract/deploy.rs
Outdated
| match receipt.contract_address { | ||
| Some(address) => Ok(Async::Ready(Contract::new(eth, address, abi))), | ||
| None => Err(Error::ContractDeploymentFailure(receipt.transaction_hash)), | ||
| let status = receipt.status.ok_or(Error::Api(ApiError::InvalidResponse(String::from( |
There was a problem hiding this comment.
It's not an error, for chains that don't support status the value will be None. Please just fall back to contratAddress detection in such case as I've suggested in the issue.
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Aug 7, 2019
We use an unreleased version of `web3` which includes a fix for silent deploy failures [1]. [1]: tomusdrw/rust-web3#242
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Aug 7, 2019
We use an unreleased version of `web3` which includes a fix for silent deploy failures [1]. [1]: tomusdrw/rust-web3#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying a contract is successful only if the
statusfield of the receipt is0x1. Before, the deployment was considered successful if the contract address was present.Fixes #241