Parse r/s values from signTransaction as U256 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parity Ethereum also returns the `r` and `s` values in the `RawTransactionDetails` response of `personal_signTransaction`. These values are encoded as `U256` instead of fixed 32 byte strings. This results in response values that have less uneven number of hex characters. For these cases deserialization of the response fails. To accomodate this case we change the type the `r` and `s` fields in `RawTransactionDetails`.
geigerzaehler
force-pushed
the
parity-raw-transaction-r-s
branch
from
b5f3c3b
to
b5bc271
Compare
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Sep 6, 2019
Patches web3 with tomusdrw/rust-web3#250 so that `sign_transaction()` works.
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Sep 6, 2019
Patches web3 with tomusdrw/rust-web3#250 so that `sign_transaction()` works.
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Sep 6, 2019
Patches web3 with tomusdrw/rust-web3#250 so that `sign_transaction()` works.
geigerzaehler
pushed a commit
to oscoin/oscoin-parity-wasm-prototype
that referenced
this pull request
Sep 9, 2019
Patches web3 with tomusdrw/rust-web3#250 so that `sign_transaction()` works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity Ethereum also returns the
randsvalues in theRawTransactionDetailsresponse ofpersonal_signTransaction. These values are encoded asU256instead of fixed 32 byte strings. This results in response values that have less uneven number of hex characters. For these cases deserialization of the response fails.To accomodate this case we change the type the
randsfields inRawTransactionDetails.