Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving HTTP_PROXY variables if set. #370

Merged
merged 6 commits into from Aug 25, 2020
Merged

Resolving HTTP_PROXY variables if set. #370

merged 6 commits into from Aug 25, 2020

Conversation

whizsid
Copy link
Contributor

@whizsid whizsid commented Aug 24, 2020

Fixes #369 .

tomusdrw
tomusdrw requested changes Aug 24, 2020
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just a tiny grumble regarding unnecessary features.

Cargo.toml Outdated Show resolved Hide resolved
@tomusdrw
Copy link
Owner

Thanks a lot!

@tomusdrw tomusdrw merged commit 3aeaa6c into tomusdrw:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect through a proxy if environment variables are set.
2 participants
@whizsid @tomusdrw