Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert contract::deploy to async #388

Merged
merged 3 commits into from Oct 18, 2020
Merged

Convert contract::deploy to async #388

merged 3 commits into from Oct 18, 2020

Conversation

e00E
Copy link
Contributor

@e00E e00E commented Oct 16, 2020

part of #361

Note that I have changed execute to return a single Result instead of nested Results by extending deploy::Error with AbiError.

tomusdrw
tomusdrw approved these changes Oct 18, 2020
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomusdrw tomusdrw merged commit 3414c66 into tomusdrw:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e00E @tomusdrw