Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Eth::uncle #406

Merged
merged 2 commits into from Dec 9, 2020
Merged

Fix Eth::uncle #406

merged 2 commits into from Dec 9, 2020

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Nov 15, 2020

No description provided.

@tomusdrw
Copy link
Owner

The API docs say the return type should be Block, but without individual transactions (so just hashes), see here:
https://eth.wiki/json-rpc/API#returns-33

Open Ethereum returns a RichBlock struct as well, not just a Header:
https://github.com/openethereum/openethereum/blob/main/rpc/src/v1/impls/eth.rs#L359

Can you provide some context for this change?

@vorot93
Copy link
Contributor Author

vorot93 commented Nov 18, 2020

Exactly what you said, basically. I'm using this library against turbo-geth's rpcdaemon and IIRC ran into abscence of TX hashes.

tomusdrw
tomusdrw approved these changes Dec 9, 2020
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've changed the API a bit to avoid breaking backward compatibility. So there is Eth::uncle_header for TurboGeth compatibility.

@tomusdrw tomusdrw merged commit 3ba5657 into tomusdrw:master Dec 9, 2020
@vorot93 vorot93 deleted the uncle-block-fix branch December 9, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vorot93 @tomusdrw