Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signing deployment transactions with a private key #473

Merged
merged 4 commits into from Mar 16, 2021

Conversation

smessmer
Copy link
Contributor

All previous API points to deploy contracts relied on the ethereum node to have the private keys for the account to deploy from. This PR adds an API for deploying contracts while keeping the private keys away from the ethereum node.

@smessmer smessmer force-pushed the feature/signed_deploy branch 2 times, most recently from b60bf94 to 284ab62 Compare March 15, 2021 01:29
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except for the gas and chain_id comments.

src/contract/deploy.rs Outdated Show resolved Hide resolved
src/contract/deploy.rs Outdated Show resolved Hide resolved
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

src/contract/deploy.rs Show resolved Hide resolved
@tomusdrw tomusdrw merged commit bd04b91 into tomusdrw:master Mar 16, 2021
@smessmer smessmer deleted the feature/signed_deploy branch March 19, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants