Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eth_getProof eth_ JSON-RPC method #569

Merged
merged 1 commit into from Nov 17, 2021

Conversation

lightyear15
Copy link
Contributor

Described in EIP-1186 [1], it is not a very well documented method,
its description is missing from many resources [2], [3], however
it is present in the current ethereum client implementation [4].

This commit adds the necesarry struct and method to add this method.

[1] https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1186.md
[2] https://eth.wiki/json-rpc/API
[3] https://github.com/ethereum/execution-apis
[4] https://github.com/ethereum/go-ethereum/blob/master/internal/web3ext/web3ext.go#L561

src/api/eth.rs Outdated Show resolved Hide resolved
src/api/eth.rs Outdated Show resolved Hide resolved
src/api/eth.rs Outdated Show resolved Hide resolved
src/types/proof.rs Outdated Show resolved Hide resolved
src/types/proof.rs Show resolved Hide resolved
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, looks great now!

@tomusdrw tomusdrw enabled auto-merge (squash) November 15, 2021 14:34
@lightyear15
Copy link
Contributor Author

great! ✌️

@tomusdrw
Copy link
Owner

@lightyear15 can you run cargo fmt on the codebase and merge latest master?

auto-merge was automatically disabled November 16, 2021 14:22

Head branch was pushed to by a user without write access

Described in EIP-1186 [1], it is not a very well documented method,
its description is missing from many resources [2], [3], however
it is present in the current ethereum client implementation [4].

This commit adds the necesarry struct and method to add this method.

[1] https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1186.md
[2] https://eth.wiki/json-rpc/API
[3] https://github.com/ethereum/execution-apis
[4] https://github.com/ethereum/go-ethereum/blob/master/internal/web3ext/web3ext.go#L561
@lightyear15
Copy link
Contributor Author

Thanks @tomusdrw ,
I have rebased and squashed all the minor commits regarding changes made during review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants