Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getProof balance and nonce to U256 #572

Merged
merged 1 commit into from Nov 30, 2021
Merged

eth_getProof balance and nonce to U256 #572

merged 1 commit into from Nov 30, 2021

Conversation

lightyear15
Copy link
Contributor

after some real-world testing, we figured balance as well as nonce
fields might reach the upper limit of U64.
Moving these fields to U256

@lightyear15
Copy link
Contributor Author

sorry about this 😞
should have then more tests before my first PR

@tomusdrw
Copy link
Owner

No worries! Could you please add a testcase for these large values as well?

eth_getProof balance and nonce to U256
3da6317 
after some real-world testing, we figured balance as well as nonce
fields might reach the upper limit of U64.
Moving these fields to U256
@lightyear15
Copy link
Contributor Author

Hi @tomusdrw
I changed the unit test as you requested.
The proof does not need to be consistent as that is not the purpose of the test. So I just changed the value of balance and nonce fields to make them more similar to a real-case.

@tomusdrw
Copy link
Owner

Perfect, thank you!

@tomusdrw tomusdrw enabled auto-merge (squash) November 30, 2021 16:16
@tomusdrw tomusdrw merged commit 1f807bb into tomusdrw:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightyear15 @tomusdrw