Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the docs for BaseFilter to mention that the filter is _not_ uninstalled on Drop #584

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Update the docs for BaseFilter to mention that the filter is _not_ uninstalled on Drop #584

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ccb007
Update the docs for BaseFilter to mention that the filter is _not_ un…
marmistrz Jan 13, 2022
67de769
Merge branch 'master' into dropdocs
tomusdrw Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/eth_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,10 @@ impl FilterInterface for PendingTransactionsFilter {
}

/// Base filter handle.
/// Uninstall filter on drop.
/// Allows to poll the filter.
///
/// Note: because Rust currently doesn't support async drop, the filter has to be uninstalled manually.
/// See [https://github.com/tomusdrw/rust-web3/issues/583](this tracking issue).
pub struct BaseFilter<T: Transport, I> {
// TODO [ToDr] Workaround for ganache returning 0x03 instead of 0x3
id: String,
Expand Down