Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rustls websocket connection as feature ws-rustls-tokio #687

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

alexheretic
Copy link
Contributor

Add feature ws-rustls-tokio as an alternative to ws-tls-tokio. This allows avoiding openssl similar to the existing http-rustls-tls feature.

As a new additional feature this is a non-breaking change.

@alexheretic
Copy link
Contributor Author

Hey @tomusdrw this would be useful for avoiding openssl, wdyt?

Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, thanks! I left a couple of suggestions though.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/transports/ws.rs Show resolved Hide resolved
src/transports/ws.rs Show resolved Hide resolved
@tomusdrw tomusdrw enabled auto-merge (squash) September 25, 2023 09:22
auto-merge was automatically disabled September 28, 2023 08:49

Head branch was pushed to by a user without write access

@alexheretic
Copy link
Contributor Author

@tomusdrw I've updated the tokio-rustls & webpki-roots dependencies. Should be ready to go now.

@alexheretic
Copy link
Contributor Author

I've updated to the latest rustls. Merge?

@tomusdrw tomusdrw merged commit 6fcad83 into tomusdrw:master Dec 19, 2023
5 checks passed
@alexheretic alexheretic deleted the ws-rustls-tokio branch December 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants