Fix: Use "filterText" (fallback to "label") for the trigger of the completion item #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An option is added to always prefer "label" over the "filterText" if the user so desires. However, certain language servers might use the "label" to denote extra data, e.g. a circular dot in front of the word-to-complete in case it returns a completion with an "additionalTextEdits" key. In this case, using the "label" for the ST trigger characters can give wrong behavior. An example of this wrong behavior is: #368
One can take a look at the completion_test.py file to get a feel for what this change entails.
ping @ayoub-benali @frou