Text editing cleanup/testability #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move response parsing to protocol Extract non-sublime-tied logic from commands Remove debugging status/logging when applying doc edits. Simplify sorting of document edits (assuming stable sorting)
rwols
reviewed
Apr 28, 2019
rwols
reviewed
Apr 28, 2019
plasticine
pushed a commit
to plasticine/LSP
that referenced
this pull request
Jun 4, 2019
* Initial cleanup Move response parsing to protocol Extract non-sublime-tied logic from commands Remove debugging status/logging when applying doc edits. Simplify sorting of document edits (assuming stable sorting) * Fix typing issues * Move commands out of core, add tests * Fix lint issue * Name tests correctly and fix data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate sublime-tied logic to plugin/edit.py.
Add tests for remaining logic (response parsing, sorting)
Remove debugging status/logging when applying doc edits.
Part of an effort to improve unit test coverage.