Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filter on comment and string for requesting hover #693

Merged
merged 1 commit into from Aug 23, 2019
Merged

Remove filter on comment and string for requesting hover #693

merged 1 commit into from Aug 23, 2019

Conversation

tomv564
Copy link
Contributor

@tomv564 tomv564 commented Aug 22, 2019

Fixes #607 and #625.
LSP will always request hover info from the server, and stop showing the No description available popup if the server has no info in the response.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 37.78% when pulling cfde2cc on hover-on-all-scopes into d85f1d7 on master.

rwols
rwols approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always in favor of removing smartness and exceptions.

@tomv564 tomv564 merged commit 679d808 into master Aug 23, 2019
@tomv564 tomv564 deleted the hover-on-all-scopes branch November 28, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwols rwols rwols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some servers provide tooltips for ignored scopes
3 participants
@tomv564 @coveralls @rwols