Simplify projectless sessions #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "switch project" detection logic was firing accidentally when switching views, causing random session shutdowns. The solution is to store the "fallback" active view path separately (_projectless_root_path) and exclude it from the switch project detection. _projectless_root_path will only be set once per window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As logs in #668 show, when running sublime without a project, sessions get restarted every time you open a file from a different folder.
The "switch project" detection logic was firing accidentally when switching files. The solution effectively disables this logic by not setting
_project_path- instead a separate_projectless_root_pathmember is used._projectless_root_pathwill only be set once per window.