Create a new line for edits after the document #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwols
previously approved these changes
Sep 14, 2019
plugin/edit.py
Outdated
| # Handle when a language server (eg gopls) inserts at a row beyond the document | ||
| # some editors create the line automatically, sublime needs to have the newline prepended. | ||
| if start[0] > last_row and newText[0] != '\n': | ||
| newText = '\n' + newText |
There was a problem hiding this comment.
Thanks for the test you wrote and the research!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690 where gopls is returning edits for a line that doesn't exist - this happens to work with VS Code because implementation details.
To do:
remove list constructor so we can just pass an iterator from sorted in(Did not work withsort_by_application_orderreversed)