Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font colour doesn't change when theme changes #95

Closed
2 tasks done
andilge opened this issue Jan 24, 2021 · 6 comments
Closed
2 tasks done

Font colour doesn't change when theme changes #95

andilge opened this issue Jan 24, 2021 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@andilge
Copy link

andilge commented Jan 24, 2021

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Release with the issue:
latest

Last working release (if known):
?

Browser and Operating System:
I was able to reproduce this in Windows 10 with Browser Chrome, Opera and Firefox and on Ubuntu 20 with Browser Chromium, Opera and Firefox

Description of problem:
I use Google Light and Dark Theme installed with HACS frm https://github.com/liri/lovelace-themes) and use an automation to set it on sunrise, sunset or home assitant atart according to sun above or below horizon. It appears that in all other cards the font color changes when the theme changes (service frontend.set_theme) but it won't change in the compass card. Reloading the page with F5 then corrects it and all sohws up nicely again.

Please find attached more dtails about the theme switcher, a lovelace card I use and 2 scrren shots on how it appears on my end.

automation theme switcher.yaml.txt
my lovelace card.yaml.txt

2020-12-22_23-31
compass card after theme change

@andilge andilge added the bug Something isn't working label Jan 24, 2021
@tomvanswam
Copy link
Owner

Thanks for the extensive report! This is first on my todo list now.

@tomvanswam tomvanswam self-assigned this Jan 25, 2021
@andilge
Copy link
Author

andilge commented Jan 25, 2021

uups, just seen I indicated the wrong theme, sry for that.

It's Google Drak Theme
https://github.com/JuanMTech/google_dark_theme

and Google Light Theme
https://github.com/JuanMTech/google_light_theme

I was also able to reproduce the effect with

iOS Dark Mode
https://github.com/JuanMTech/ios_dark_mode_theme

and iOS LightMode
https://github.com/JuanMTech/ios_dark_mode_theme

NB: all these themes come from @JuanMTech.

@andilge
Copy link
Author

andilge commented Feb 13, 2021

hey @tomvanswam, all fine on your side?

sry for being inpatient, any update on this yet?

@tomvanswam
Copy link
Owner

Unfortunately my spare time is very limted at the moment. So no real progress. Also some issues with my dev environment took up some time, but that should be fixed now.
Expect news within a month.

@tomvanswam tomvanswam added this to the v1.1.1 milestone Feb 14, 2021
@tomvanswam
Copy link
Owner

Found the problem, now to fix it ;-)

@andilge
Copy link
Author

andilge commented Feb 14, 2021

cool, you're the man. tnx for this update. looking forward to the v1.1.1 milestone :-)

@tomvanswam tomvanswam mentioned this issue Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants