Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packages, clean up code etc #15

Closed
tomwilkie opened this issue Aug 30, 2016 · 5 comments
Closed

Use packages, clean up code etc #15

tomwilkie opened this issue Aug 30, 2016 · 5 comments

Comments

@tomwilkie
Copy link
Owner

No description provided.

@tomwilkie tomwilkie added this to the SF Prometheus Meetup milestone Sep 6, 2016
@jml
Copy link
Collaborator

jml commented Sep 6, 2016

@tomwilkie This will need a better description if someone else can attempt it.

@tomwilkie
Copy link
Owner Author

I guess we probably want a package for each component - ingestor, distributor, querier?

And by code cleaner I just mean removing TODOs, adding unit tests, improving code smells, better decoupling, be more stringent in code reviews.

@jml
Copy link
Collaborator

jml commented Sep 6, 2016

OK. I suggest we make the package-per-component bit the thing for this ticket and do the other stuff incrementally as we make other changes.

@tomwilkie
Copy link
Owner Author

Agreed!
On Tue, 6 Sep 2016 at 17:59, Jonathan Lange notifications@github.com
wrote:

OK. I suggest we make the package-per-component bit the thing for this
ticket and do the other stuff incrementally as we make other changes.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbGhUCp0joiJJBAzlXsvmZx0xgVbwD8ks5qnZvDgaJpZM4Jwsaz
.

@jml
Copy link
Collaborator

jml commented Sep 9, 2016

This issue was moved to cortexproject/cortex#16

@jml jml closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants