Store entire ring under single key in Consul. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
better-ring
branch
from
3b68b46
to
2e0f84d
Compare
tomwilkie
force-pushed
the
better-ring
branch
from
2e0f84d
to
95be339
Compare
| Get(key string, factory InstanceFactory) error | ||
| CAS(key string, factory InstanceFactory, f CASCallback) error | ||
| WatchPrefix(path string, factory InstanceFactory, done chan struct{}, f func(string, interface{}) bool) | ||
| WatchKey(key string, factory InstanceFactory, done chan struct{}, f func(interface{}) bool) |
There was a problem hiding this comment.
Please update the doc comment with a note about InstanceFactory.
| populateRingDesc(ringDesc, r.id, r.hostname, tokens) | ||
|
|
||
| return ringDesc, true, nil | ||
| }); err != nil { |
There was a problem hiding this comment.
This took me quite a while to figure out. Here are some things that I think might help make it easier to follow:
- Separate assigning to
errfrom theerr != nilcheck - Define the function being passed to
CASseparately and give it a name. Maketokensa parameter of that function and close overtokenshere.
|
Done my first pass review. I'll wait until you give me a heads up before doing a second pass. Looks really good though! |
| maxBackoff = 1 * time.Minute | ||
| ) | ||
| var ( | ||
| backoff = initialBackoff / 2 |
|
What's your testing strategy for this? |
|
A few more questions. I promise the final round of review will be very quick. |
I've run this all locally and tested killing all the various components in various orders. |
|
LGTM, thanks. In a future PR, we should automate those tests you did. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8