Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use pyproject.toml #69

Closed
hhamana opened this issue Jun 5, 2022 · 2 comments · Fixed by #83
Closed

Properly use pyproject.toml #69

hhamana opened this issue Jun 5, 2022 · 2 comments · Fixed by #83
Assignees
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code

Comments

@hhamana
Copy link
Collaborator

hhamana commented Jun 5, 2022

The pyproject.toml we use is currently only for black config.
While that's fine and all, pyproject.toml is originally intended to define the build system, and replace setup.cfg, which itself is already supposed to be a safer alternative to the setup.py
As build system, using the status quo default setuptools is fine for us. But we have to be explicit about it. Latest updates to pip issue a DeprecatedWarning to systems still using setup.py or setup.cfg to define project metadata.

recommended reading:

@tomwojcik
Copy link
Owner

But we have to be explicit about it. Latest updates to pip issue a DeprecatedWarning to systems still using setup.py or setup.cfg to define project metadata.

That's a valid point. I tried to go 100% pyproject.toml many times but many libraries were lacking proper support. I'll try to move everything there after the next release (and ditch setup.py). This deprecation warning is a good enough reason to give it another try.

@tomwojcik tomwojcik self-assigned this Jun 5, 2022
@tomwojcik tomwojcik added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Jun 5, 2022
@hhamana
Copy link
Collaborator Author

hhamana commented Jun 5, 2022

move everything there

unfortunately I think yapf still does not support configuration through pyproject.toml, so not everything can be moved.
but that's fine, we can keep the setup.cfg for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants