Skip to content

Commit

Permalink
Change indentation to tabs
Browse files Browse the repository at this point in the history
  • Loading branch information
@emmetog
emmetog committed Feb 12, 2018
1 parent e6cb7e2 commit 4f565b6
Show file tree
Hide file tree
Showing 2 changed files with 182 additions and 173 deletions.
17 changes: 17 additions & 0 deletions .editorconfig
View file
@@ -0,0 +1,17 @@
; This file is for unifying the coding style for different editors and IDEs.
; More information at http://editorconfig.org

root = true

[*]
indent_style = tab
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

[*.bat]
end_of_line = crlf

[*.yml]
indent_style = space
indent_size = 2
338 changes: 165 additions & 173 deletions src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php
View file
Expand Up @@ -21,177 +21,169 @@

class ClassMethodAnalyzer
{
protected $context;
protected $fileBefore;
protected $fileAfter;

/**
* @param string $context
* @param string $fileBefore
* @param string $fileAfter
*/
public function __construct($context, $fileBefore = null, $fileAfter = null)
{
$this->context = $context;
$this->fileBefore = $fileBefore;
$this->fileAfter = $fileAfter;
}

public function analyze(Stmt $contextBefore, Stmt $contextAfter)
{
$report = new Report();

$methodsBefore = $contextBefore->getMethods();
$methodsAfter = $contextAfter->getMethods();

$methodsBeforeKeyed = [];
foreach ($methodsBefore as $method) {
$methodsBeforeKeyed[strtolower($method->name)] = $method;
}

$methodsAfterKeyed = [];
foreach ($methodsAfter as $method) {
$methodsAfterKeyed[strtolower($method->name)] = $method;
}

// Here we only care about public methods as they are the only part of the API we care about

$methodNamesNotAddedOrRemoved = [];

foreach($methodsBefore as $methodBefore)
{
// Removed methods can either be implemented in parent classes or not exist anymore
if($this->wasMethodRemoved($methodBefore, $methodsAfter))
{
$data = new ClassMethodRemoved($this->context, $this->fileBefore, $contextBefore, $methodBefore);
$report->add($this->context, $data);
} else {
$methodNamesNotAddedOrRemoved[strtolower($methodBefore->name)] = true;
}
}

foreach($methodsAfter as $methodAfter)
{
// Added methods implies MINOR BUMP
if($this->wasMethodAdded($methodAfter, $methodsBefore))
{
$data = new ClassMethodAdded($this->context, $this->fileAfter, $contextAfter, $methodAfter);
$report->add($this->context, $data);
} else {
$methodNamesNotAddedOrRemoved[strtolower($methodAfter->name)] = true;
}
}

foreach (array_keys($methodNamesNotAddedOrRemoved) as $methodName) {

/** @var \PhpParser\Node\Stmt\ClassMethod $methodBefore */
$methodBefore = $methodsBeforeKeyed[$methodName];
/** @var \PhpParser\Node\Stmt\ClassMethod $methodAfter */
$methodAfter = $methodsAfterKeyed[$methodName];

if (!$this->areMethodsEqual($methodBefore, $methodAfter)) {

$paramsBefore = $methodBefore->params;
$paramsAfter = $methodAfter->params;

$signatureResult = Signature::analyze($paramsBefore, $paramsAfter);

$changes = [
'parameter_added' => ClassMethodParameterAdded::class,
'parameter_removed' => ClassMethodParameterRemoved::class,
'parameter_renamed' => ClassMethodParameterNameChanged::class,
'parameter_typing_added' => ClassMethodParameterTypingAdded::class,
'parameter_typing_removed' => ClassMethodParameterTypingRemoved::class,
'parameter_default_added' => ClassMethodParameterDefaultAdded::class,
'parameter_default_removed' => ClassMethodParameterDefaultRemoved::class,
'parameter_default_value_changed' => ClassMethodParameterDefaultValueChanged::class,
];

foreach ($changes as $changeType => $class) {
if (!$signatureResult[$changeType]) {
continue;
}
if (is_a($class, ClassMethodOperationUnary::class, true)) {
$data = new $class($this->context, $this->fileAfter, $contextAfter, $methodAfter);
} else {
$data = new $class(
$this->context,
$this->fileBefore,
$contextBefore,
$methodBefore,
$this->fileAfter,
$contextAfter,
$methodAfter
);
}
$report->add($this->context, $data);
}

// Difference in source code
// Cast to array because interfaces do not have stmts (= null)
if (!Implementation::isSame((array)$methodBefore->stmts, (array)$methodAfter->stmts)) {
$data = new ClassMethodImplementationChanged(
$this->context,
$this->fileBefore,
$contextBefore,
$methodBefore,
$this->fileAfter,
$contextAfter,
$methodAfter
);
$report->add($this->context, $data);
}
}
}

return $report;
}

private function areMethodsEqual(Stmt\ClassMethod $methodBefore, Stmt\ClassMethod $methodAfter)
{
if ($methodBefore == $methodAfter) {
return true;
};

return strtolower($methodBefore->name) === strtolower($methodAfter->name)
&& $methodBefore->isPrivate() === $methodAfter->isPrivate()
&& $methodBefore->isAbstract() === $methodAfter->isAbstract()
&& $methodBefore->isFinal() === $methodAfter->isFinal()
&& $methodBefore->isProtected() === $methodAfter->isProtected()
&& $methodBefore->isPublic() === $methodAfter->isPublic()
&& $methodBefore->isStatic() === $methodAfter->isStatic()
&& $methodBefore->getReturnType() === $methodAfter->getReturnType()
// statements are objects, cannot be compared with ===
&& $methodBefore->getStmts() == $methodAfter->getStmts()
&& $methodBefore->getParams() === $methodAfter->getParams()
&& $methodBefore->returnsByRef() === $methodAfter->returnsByRef()
&& $methodBefore->getType() === $methodAfter->getType()
&& $methodBefore->getAttributes() === $methodAfter->getAttributes();
}

private function wasMethodAdded(Stmt\ClassMethod $method, $methodsAfter)
{
foreach($methodsAfter as $methodAfter)
{
if(strtolower($method->name) == strtolower($methodAfter->name))
{
return false;
}
}

return true;
}

private function wasMethodRemoved(Stmt\ClassMethod $method, $methodsBefore)
{
foreach($methodsBefore as $methodBefore)
{
if(strtolower($method->name) == strtolower($methodBefore->name))
{
return false;
}
}

return true;
}
protected $context;
protected $fileBefore;
protected $fileAfter;

/**
* @param string $context
* @param string $fileBefore
* @param string $fileAfter
*/
public function __construct($context, $fileBefore = null, $fileAfter = null)
{
$this->context = $context;
$this->fileBefore = $fileBefore;
$this->fileAfter = $fileAfter;
}

public function analyze(Stmt $contextBefore, Stmt $contextAfter)
{
$report = new Report();

$methodsBefore = $contextBefore->getMethods();
$methodsAfter = $contextAfter->getMethods();

$methodsBeforeKeyed = [];
foreach ($methodsBefore as $method) {
$methodsBeforeKeyed[strtolower($method->name)] = $method;
}

$methodsAfterKeyed = [];
foreach ($methodsAfter as $method) {
$methodsAfterKeyed[strtolower($method->name)] = $method;
}

// Here we only care about public methods as they are the only part of the API we care about

$methodNamesNotAddedOrRemoved = [];

foreach ($methodsBefore as $methodBefore) {
// Removed methods can either be implemented in parent classes or not exist anymore
if ($this->wasMethodRemoved($methodBefore, $methodsAfter)) {
$data = new ClassMethodRemoved($this->context, $this->fileBefore, $contextBefore, $methodBefore);
$report->add($this->context, $data);
} else {
$methodNamesNotAddedOrRemoved[strtolower($methodBefore->name)] = true;
}
}

foreach ($methodsAfter as $methodAfter) {
// Added methods implies MINOR BUMP
if ($this->wasMethodAdded($methodAfter, $methodsBefore)) {
$data = new ClassMethodAdded($this->context, $this->fileAfter, $contextAfter, $methodAfter);
$report->add($this->context, $data);
} else {
$methodNamesNotAddedOrRemoved[strtolower($methodAfter->name)] = true;
}
}

foreach (array_keys($methodNamesNotAddedOrRemoved) as $methodName) {

/** @var \PhpParser\Node\Stmt\ClassMethod $methodBefore */
$methodBefore = $methodsBeforeKeyed[$methodName];
/** @var \PhpParser\Node\Stmt\ClassMethod $methodAfter */
$methodAfter = $methodsAfterKeyed[$methodName];

if (!$this->areMethodsEqual($methodBefore, $methodAfter)) {

$paramsBefore = $methodBefore->params;
$paramsAfter = $methodAfter->params;

$signatureResult = Signature::analyze($paramsBefore, $paramsAfter);

$changes = [
'parameter_added' => ClassMethodParameterAdded::class,
'parameter_removed' => ClassMethodParameterRemoved::class,
'parameter_renamed' => ClassMethodParameterNameChanged::class,
'parameter_typing_added' => ClassMethodParameterTypingAdded::class,
'parameter_typing_removed' => ClassMethodParameterTypingRemoved::class,
'parameter_default_added' => ClassMethodParameterDefaultAdded::class,
'parameter_default_removed' => ClassMethodParameterDefaultRemoved::class,
'parameter_default_value_changed' => ClassMethodParameterDefaultValueChanged::class,
];

foreach ($changes as $changeType => $class) {
if (!$signatureResult[$changeType]) {
continue;
}
if (is_a($class, ClassMethodOperationUnary::class, true)) {
$data = new $class($this->context, $this->fileAfter, $contextAfter, $methodAfter);
} else {
$data = new $class(
$this->context,
$this->fileBefore,
$contextBefore,
$methodBefore,
$this->fileAfter,
$contextAfter,
$methodAfter
);
}
$report->add($this->context, $data);
}

// Difference in source code
// Cast to array because interfaces do not have stmts (= null)
if (!Implementation::isSame((array)$methodBefore->stmts, (array)$methodAfter->stmts)) {
$data = new ClassMethodImplementationChanged(
$this->context,
$this->fileBefore,
$contextBefore,
$methodBefore,
$this->fileAfter,
$contextAfter,
$methodAfter
);
$report->add($this->context, $data);
}
}
}

return $report;
}

private function areMethodsEqual(Stmt\ClassMethod $methodBefore, Stmt\ClassMethod $methodAfter)
{
if ($methodBefore == $methodAfter) {
return true;
};

return strtolower($methodBefore->name) === strtolower($methodAfter->name)
&& $methodBefore->isPrivate() === $methodAfter->isPrivate()
&& $methodBefore->isAbstract() === $methodAfter->isAbstract()
&& $methodBefore->isFinal() === $methodAfter->isFinal()
&& $methodBefore->isProtected() === $methodAfter->isProtected()
&& $methodBefore->isPublic() === $methodAfter->isPublic()
&& $methodBefore->isStatic() === $methodAfter->isStatic()
&& $methodBefore->getReturnType() === $methodAfter->getReturnType()
// statements are objects, cannot be compared with ===
&& $methodBefore->getStmts() == $methodAfter->getStmts()
&& $methodBefore->getParams() === $methodAfter->getParams()
&& $methodBefore->returnsByRef() === $methodAfter->returnsByRef()
&& $methodBefore->getType() === $methodAfter->getType()
&& $methodBefore->getAttributes() === $methodAfter->getAttributes();
}

private function wasMethodAdded(Stmt\ClassMethod $method, $methodsAfter)
{
foreach ($methodsAfter as $methodAfter) {
if (strtolower($method->name) == strtolower($methodAfter->name)) {
return false;
}
}

return true;
}

private function wasMethodRemoved(Stmt\ClassMethod $method, $methodsBefore)
{
foreach ($methodsBefore as $methodBefore) {
if (strtolower($method->name) == strtolower($methodBefore->name)) {
return false;
}
}

return true;
}
}

0 comments on commit 4f565b6

Please sign in to comment.