Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chord.get throws exception on some strings #407

Closed
lheckemann opened this issue Jan 31, 2024 · 0 comments · Fixed by #409
Closed

Chord.get throws exception on some strings #407

lheckemann opened this issue Jan 31, 2024 · 0 comments · Fixed by #409
Labels
bug

Comments

@lheckemann
Copy link

Until recently, I was throwing strings into Chord.get indiscriminately and checking the tonic and quality to determine whether it was valid, since it returns NoChord when it can't be parsed.

However, it seems to throw an exception when certain non-chord strings are passed in, e.g. |\n (space, pipe, newline).
@danigb danigb added the bug label Feb 1, 2024
danigb added a commit that referenced this issue Feb 3, 2024
@danigb
fix: exception in note tokenizer. Fixes #407
859494b
@danigb danigb mentioned this issue Feb 3, 2024
Merged
danigb added a commit that referenced this issue Feb 3, 2024
@danigb
Fix/note tokenize (#409)
661bfdb 
* fix: exception in note tokenizer. Fixes #407

* chore: version

* chore: remove husky

* chore: version bump

* fix: update chord dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/note tokenize tonaljs/tonal
2 participants
@danigb @lheckemann