Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with newest protocol #25

Merged
merged 8 commits into from Jul 14, 2021
Merged

Update to work with newest protocol #25

merged 8 commits into from Jul 14, 2021

Conversation

efyang
Copy link
Contributor

@efyang efyang commented Jul 8, 2021

Adds dial turn flashing, uses new Led command, and allows for pulse interval setting as well. Waiting on #24.

Cargo.toml Outdated Show resolved Hide resolved
@efyang efyang marked this pull request as ready for review July 9, 2021 08:27
@efyang efyang mentioned this pull request Jul 9, 2021
@bschwind
Copy link
Member

I see the Cargo.toml change in the commits, but not in the overall diff. Has something weird happened with the commit history?

@efyang
Copy link
Contributor Author

efyang commented Jul 14, 2021

The original repo was actually already using "0.4" in the Cargo.toml file (even though that didn't exist yet), so the changes in the commits were purely to change only the Cargo.lock file and to test the PR while the panel-protocol PR hadn't been merged yet.

@bschwind
Copy link
Member

I see, I think I made some confusion by depending on a 0.4 version even though it didn't exist yet...or something, I'm not quite sure how that went down.

Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to work, LGTM!

@bschwind bschwind merged commit 96c9faa into main Jul 14, 2021
@bschwind bschwind deleted the led-protocol-update branch July 14, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants