Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type; patch #49

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix Type; patch #49

merged 2 commits into from
Jul 12, 2023

Conversation

rob-gordon
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graph-selector-syntax ❌ Failed (Inspect) Jul 12, 2023 2:24pm

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (17c6c2b) 99.62% compared to head (a52d804) 99.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          15       15           
  Lines         536      536           
  Branches      141      141           
=======================================
  Hits          534      534           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rob-gordon
Copy link
Member Author

Merging even though Next won't build. Has to do with shared modules in a monorepo settings and the type fix is more important than public docs for the moment. Need to replace Next with Vite or build from scratch in the future.

@rob-gordon rob-gordon merged commit 91863ce into main Jul 12, 2023
4 of 5 checks passed
@rob-gordon rob-gordon deleted the fix-types branch July 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant