Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals inherit Signal.connect method #11

Closed
tambien opened this issue Aug 22, 2014 · 0 comments
Closed

Signals inherit Signal.connect method #11

tambien opened this issue Aug 22, 2014 · 0 comments
Milestone

Comments

@tambien
Copy link
Contributor

tambien commented Aug 22, 2014

All classes in the signal folder should borrow the Signal.connect method which zeros out the value of the Param or Signal which is it connect to so that the Signal can get full control over the output value without being summed with the current Param or Signal's value. This will save having to manually zero out the connected parameter which is not intuitive.

Not sure what the best way to handle this is. Possibly just doing something like this would work:

Tone.[Class].prototype.connect = Tone.Signal.prototype.connect

Also, not sure how to handle this case in the jsdocs.

tambien added a commit that referenced this issue Aug 24, 2014
this is so that params and signals they connect to don’t need to be
manually zeroed out after connecting.

Fixed #11
@tambien tambien closed this as completed Aug 24, 2014
@tambien tambien added this to the Version 1 milestone Aug 24, 2014
tambien added a commit that referenced this issue Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant