code reviews #1
Open
code reviews #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add full functions and styles to the page
Add more functionality and styles to the project
Add full website functionality
cwaku
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
hi @tongoonamujera,
Amazing work you've done so far.
- Descriptive commit messages ✅
- You followed DRY, KISS, and YAGNI rules. ✅
You followed all the basic best practices. Your project is complete! Feel free to merge Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Optional
- Consider setting 'mode' to development or production in order to avoid warnings at the beginning of your app. https://webpack.js.org/configuration/mode/
- Please give more description to your Pull requests so the review knows what's been before diving into the review process
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add changes to code