Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BUX-139): panic if miner wasn't found #96

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

witalij-4chain
Copy link

No description provided.

@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Jul 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

Welcome to our open-source project @vitalibalashka! 💘

@@ -157,7 +157,7 @@ func (c *Client) PolicyQuote(ctx context.Context, miner *Miner) (*PolicyQuoteRes

// GetPolicyData will return the policy data from the mapi adapter
func (a *PolicyQuoteMapiAdapter) GetPolicyData() *PolicyPayload {
// Tworzenie instancji UnifiedFeePayload
// Creates instance of UnifiedFeePayload

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather remove entirely, please

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #96 (2fa5b87) into master (86715bc) will decrease coverage by 0.40%.
The diff coverage is 10.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   66.85%   66.45%   -0.40%     
==========================================
  Files          11       11              
  Lines        1089     1094       +5     
==========================================
- Hits          728      727       -1     
- Misses        318      324       +6     
  Partials       43       43              
Flag Coverage Δ
unittests 66.45% <10.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fee_quote.go 82.97% <0.00%> (-1.97%) ⬇️
query_transaction.go 55.78% <0.00%> (-1.57%) ⬇️
policy_quote.go 62.09% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86715bc...2fa5b87. Read the comment docs.

@mrz1836 mrz1836 merged commit 340b194 into tonicpow:master Jul 24, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants