Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #365

Open
ArchDemons opened this issue Apr 12, 2020 · 8 comments
Open

Remove deprecated code #365

ArchDemons opened this issue Apr 12, 2020 · 8 comments

Comments

@ArchDemons
Copy link
Collaborator

It is very difficult to match the new code with the old one. It is very difficult to understand which code has already been ported, and which is not yet.

I suggest in deprecated classes to add "see" documentation help to find a new classes.
I propose to clear methods whose functionality has been transferred to new classes, while maintaining the health of the code.

So we will know which code we still need, and which we have 100% transferred to the new classes.

@tonihele
Copy link
Owner

tonihele commented Apr 12, 2020

Basically

  • toniarts.openkeeper.ai.creature.*
  • toniarts.openkeeper.world.*

are deprecated.

Most of the functionality have been ported. It is not exactly 1:1, but pretty close. It was certainly easier to port that way than to come up with totally new structure on top of a totally new architecture. Notable exceptions are:

  • Effects

Some minor things are still left but I would still say that we have more than we used to.

@ArchDemons
Copy link
Collaborator Author

We must remove methods that are no longer used and do not contain valuable code. For instance,

public void someMethod() {
   // deprecated
}

@tonihele
Copy link
Owner

tonihele commented Apr 12, 2020

Remember the @Deprecated annotation :)

@ArchDemons
Copy link
Collaborator Author

But annotation on method. Not only on class. So we will know that the method is completely transferred to a new class.

@ArchDemons
Copy link
Collaborator Author

I would even say that you need to chage deprecated classes into dummy classes. There will be methods in the classess, but without logic

@Trass3r
Copy link
Contributor

Trass3r commented Mar 9, 2022

The old code being still around is indeed confusing.

@tonihele
Copy link
Owner

I think I can remove them soon. There is only the effects I wish to salvage, but other than that I don't think there are any references anymore. Moving MainMenu and the ModelViewer was the last big work

@Trass3r
Copy link
Contributor

Trass3r commented Apr 12, 2023

Yeah this should be done before development comes to a halt since it requires deep knowledge about all the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants