Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read chunk data only right before sending #6

Merged
merged 1 commit into from
May 17, 2022
Merged

fix: read chunk data only right before sending #6

merged 1 commit into from
May 17, 2022

Conversation

troggy
Copy link
Contributor

@troggy troggy commented May 17, 2022

This way we are not keeping the whole file in memory which may fail on large files.

Closes #5

@troggy
fix: read chunk data right before sending
c854501 
This way we are not keeping the whole file in memory which may fail on large files
@toniopelo
Copy link
Owner

This is great thanks a lot @troggy !
This is a breaking change as the MultipartUploadChunk is user facing in some custom handlers, but as stated in the README, this module in its early phase (0.x.x) is subject to breaking changes so I think it's fine.
It makes me think that we definitely need to have some testing on this repo to avoid these kind of situations to go un-noticed.

@toniopelo toniopelo changed the base branch from master to development May 17, 2022 17:46
@toniopelo toniopelo added the breaking change This involve a breaking change label May 17, 2022
@toniopelo
Copy link
Owner

I added a breaking change label for people to filter out what did change lastly. One on the 1.x.x versions, semver will apply.
I'll merge this now and release right after.

@toniopelo toniopelo merged commit a1af2f5 into toniopelo:development May 17, 2022
@toniopelo
Copy link
Owner

Released under @modbox/s3-uploads-client@0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toniopelo toniopelo toniopelo approved these changes

Assignees
No one assigned
Labels
breaking change This involve a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The client is failing for large files
2 participants
@troggy @toniopelo