Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on FreeBSD #102

Closed
wants to merge 2 commits into from
Closed

Fix compilation on FreeBSD #102

wants to merge 2 commits into from

Conversation

gizahNL
Copy link

@gizahNL gizahNL commented May 3, 2021

Currently fsutil is not building on FreeBSD, these changes make it build (again?)

tonistiigi
tonistiigi requested changes May 13, 2021
View reviewed changes
Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL the CI failures. Also, add freebsd to the cross target so it is verified in CI.

@gizahNL
Copy link
Author

gizahNL commented May 13, 2021

PTAL the CI failures. Also, add freebsd to the cross target so it is verified in CI.

I'll fix it up tonight :)

thaJeztah
thaJeztah reviewed Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is green now; I left one nit (also probably needs commits to be squashed; at least the second commit)

copy/copy_freebsdsolaris.go Outdated Show resolved Hide resolved
@thaJeztah
Copy link
Collaborator

@tonistiigi ptal

gizahNL and others added 2 commits June 12, 2021 13:13
@gizahNL @thaJeztah
Fix compilation on FreeBSD
c92c5c2 
Update copy/copy_freebsdsolaris.go

Co-authored-by: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com>
@gizahNL
Add FreeBSD amd64 & i386 targets to cross build
08b160f
@gizahNL
Copy link
Author

gizahNL commented Jun 12, 2021

ptal

@tonistiigi
Copy link
Owner

#109

@tonistiigi tonistiigi closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi requested changes

@thaJeztah thaJeztah thaJeztah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gizahNL @thaJeztah @tonistiigi