go amd64 variant support #63
Conversation
crazy-max
force-pushed
the
goamd64
branch
3 times, most recently
from
80aae26
to
6388dbc
Compare
crazy-max
force-pushed
the
goamd64
branch
3 times, most recently
from
7677a62
to
188efd0
Compare
src/xx-info
Outdated
| @@ -147,6 +160,18 @@ if [ -z "$TARGETARCH" ]; then | |||
| "x86_64") | |||
| TARGETARCH="amd64" | |||
| ;; | |||
| "x86_64-v2") | |||
There was a problem hiding this comment.
How are these values possible?
There was a problem hiding this comment.
Didn't know what I was thinking about but was looking at LLVM march handling with -march=x86-64-v[234]: llvm/llvm-project@012dd42#diff-ec770381d76c859f5f572db789175fe44410a72608f58ad5dbb14335ba56eb97R193
I guess we should check cpu features to handle that?
There was a problem hiding this comment.
Don't think this should be implied from current system at all. Building in v4 system does not mean that the default build target should be v4. It should still be v1 for max compatibility.
There was a problem hiding this comment.
It should still be v1 for max compatibility.
Good point
There was a problem hiding this comment.
I wonder if we should automatically set llvm/llvm-project@012dd42e027e in cfg file for clang12+ as well if set. This could be a follow-up as well.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
No description provided.