Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NOSCRIPT to the exception message returned by EvalShaCommand when the script is not available #27

Closed
mionker opened this issue Oct 25, 2018 · 1 comment
Closed

Add NOSCRIPT to the exception message returned by EvalShaCommand when the script is not available #27

mionker opened this issue Oct 25, 2018 · 1 comment
Assignees
@tonivade
Labels
enhancement
Milestone
1.4.1

Comments

@mionker
Copy link

mionker commented Oct 25, 2018

If the Spring Redis DefaultScriptExecutor finds NOSCRIPT in the exception message after calling EVALSHA, it will try again with EVAL.
@tonivade
Copy link
Owner

Thanks @mionker I missed this part of the spec of Redis evalsha command

tonivade pushed a commit that referenced this issue Oct 27, 2018
fix for #27
eab7130 
I miss this part of the command spec. Now the command is throwing
an exception and an standard error is returned to the client.

I have change the in order to return and appropiate error in order
to fullfil the spec
@tonivade tonivade self-assigned this Oct 27, 2018
@tonivade tonivade added this to the 1.4.1 milestone Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonivade tonivade

Labels
enhancement
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@tonivade @mionker