Contest2024/submission #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 15, 2024 16:06
This reverts commit 28a0303.
# Conflicts: # LocalPackages/App/Sources/App/BuyModule/Flows/BuyCoordinator.swift # LocalPackages/App/Sources/App/SettingsModule/Sources/Modules/SettingsList/SettingsListViewModel.swift # LocalPackages/core-swift/Sources/KeeperCore/API/TonkeeperAPI/TonkeeperAPI.swift
This reverts commit 692c8ce. # Conflicts: # Configurations/Signing/SignDebug.xcconfig # Tonkeeper/Resources/Info.plist
added 3 commits
May 29, 2024 21:01
|
Telegram contact: https://t.me/spail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buy/sell feature. Some notes:
As suggested in contest discussion chat I did use results of existing (/fiat/methods/) and new (https://boot.tonkeeper.com/widget/) APIs. However, it is still not enough, as URLs for sell methods in /fiat/methods/ are incorrect (crypto currency and fiat currency params are reversed), and thus an incorrect amount is opened in web view. I could fix it with more hacks like constructing URLs on the client, but I decided not to. Buy works fine.
Also I asked in contest chat how payment methods list and country selection on initial buy/sell screen should be implemented, and I was told that they are out of the scope, so they are not present in the UI.
Sorry, I decided to delete UglyBuyList module in my PR. Press F 馃
I did add some validation for input data on the initial buy/sell screen, although min amount is hardcoded, later we can get other values to perform checks on the last screen.
I would also add an "empty results" view on the operator selection screen, although it is not present in the design.