Parse temperature and humidity from GVH5101 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small patch to correctly parse temperature and humidity information from GVH5101 devices that has reports values at different offsets than GVH5075/GVH5074. Reusing the existing file given the similarities of the two devices. Device type detection based on signature in advertising packet.
|
This is great! We discussed this in discord, but I'm putting here for the record. Referring to another reference, it looks like that model number needs the same treatment of negative temp as the 5075. So, we can move the block that flips the basenum to after the device choice if statement. Also, if you refer to the ATCpvvx driver, I list out 3 aliases for the driver at the bottom This should now support: GVH5072, GVH5075, GVH5101, and GVH5102. So, let's do the same thing here. There's also a spot in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to correctly parse temperature and humidity information from GVH5101 devices that has reports values at different offsets than GVH5075/GVH5074. Reusing the existing file given the similarities of the two devices. Device type detection based on signature in advertising packet.
I could see an argument in keeping device type files separate (i.e., a new file for GVH5101), but it felt somewhat wasteful with ~80% of the file staying the same.