LIHADOOP-43781: TonY should support enforcing maximum total number of tasks #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2019 12:15
hungj
reviewed
Feb 5, 2019
| static void validateTonyConf(Configuration tonyConf) { | ||
| int maxTasks = tonyConf.getInt(TonyConfigurationKeys.TONY_MAX_TASKS, -1); | ||
| if (maxTasks >= 0) { | ||
| int numRequestedTasks = Utils.parseContainerRequests(tonyConf).values().stream() |
There was a problem hiding this comment.
This seems fine, but have we considered whether we want a per-jobtype limit or an aggregate limit?
There was a problem hiding this comment.
That's a good idea. I'll add per-jobtype limit support, too (e.g.: tony.worker.max-tasks).
There was a problem hiding this comment.
In my latest commit, added tony.X.max-instances and renamed the global limit to tony.task.max-total-instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #169.
tony.X.max-instancesandtony.task.max-total-instancesconfigs that allow limiting the number of X instances or total task instances a job can request.RuntimeExceptionif violated