Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role typings and documentation #394

Merged
merged 16 commits into from Oct 7, 2023
Merged

Role typings and documentation #394

merged 16 commits into from Oct 7, 2023

Conversation

tony
Copy link
Owner

@tony tony commented Oct 7, 2023

Changes

  • docs(roles): Add typings to docs, split ToC
  • docs(roles): Impove docstrings
  • Rename GenericUrlRoleFn -> RoleFnReturnValue

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #394 (8c48e06) into master (5dd3ebc) will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   66.55%   66.58%   +0.02%     
==========================================
  Files          43       43              
  Lines        1214     1215       +1     
==========================================
+ Hits          808      809       +1     
  Misses        406      406              
Files Coverage Δ
src/django_docutils/lib/roles/email.py 50.00% <100.00%> (ø)
src/django_docutils/lib/roles/file.py 17.94% <ø> (ø)
src/django_docutils/lib/roles/github.py 35.71% <100.00%> (ø)
src/django_docutils/lib/roles/hackernews.py 50.00% <100.00%> (ø)
src/django_docutils/lib/roles/kbd.py 36.36% <ø> (ø)
src/django_docutils/lib/roles/leanpub.py 38.46% <100.00%> (ø)
src/django_docutils/lib/roles/pypi.py 50.00% <100.00%> (ø)
src/django_docutils/lib/roles/readthedocs.py 38.46% <100.00%> (ø)
src/django_docutils/lib/roles/twitter.py 41.66% <100.00%> (ø)
src/django_docutils/lib/roles/types.py 81.81% <100.00%> (+1.81%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the role-fn-tuple branch 2 times, most recently from caa7d52 to b8e71e4 Compare October 7, 2023 14:41
@tony tony merged commit 0e9ebec into master Oct 7, 2023
7 checks passed
@tony tony deleted the role-fn-tuple branch October 7, 2023 15:17
tony added a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant