Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests #404

Merged
merged 17 commits into from Nov 18, 2023
Merged

More tests #404

merged 17 commits into from Nov 18, 2023

Conversation

tony
Copy link
Owner

@tony tony commented Oct 28, 2023

For more sustainability, while it's fresh on the mind.

Changes

  • test: Remove empty curly brackets from Context
  • Start adding tests for docutils roles
  • More test coverage

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (112f4ce) 67.86% compared to head (8dea857) 73.13%.

❗ Current head 8dea857 differs from pull request most recent head ac2d4c4. Consider uploading reports for the commit ac2d4c4 to get more accurate results

Files Patch % Lines
tests/test_docutils_roles.py 84.21% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   67.86%   73.13%   +5.26%     
==========================================
  Files          43       43              
  Lines        1170     1124      -46     
==========================================
+ Hits          794      822      +28     
+ Misses        376      302      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the more-tests branch 9 times, most recently from 5d708eb to 7509879 Compare November 4, 2023 16:38
@tony tony force-pushed the more-tests branch 2 times, most recently from 127726c to c95590e Compare November 18, 2023 08:52
============================== warnings summary ===============================
tests/test_docutils_roles.py::test_templatetag_gh_role
tests/test_docutils_roles.py::test_templatetag_gh_role
tests/test_docutils_roles.py::test_templatetag_gh_role
tests/test_docutils_roles.py::test_templatetag_gh_role
tests/test_docutils_roles.py::test_templatetag_gh_role
  src/django_docutils/lib/roles/common.py:72: DeprecationWarning: nodes.Text: initialization argument "rawsource" is ignored and will be removed in Docutils 2.0.
    sn = innernodeclass(title, title)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================= 19 passed, 5 warnings in 0.85s ========================
settings.TEMPLATES is basically immutable after settings initialie, and tmp_path
is not available beforehand to augment settings, therefore, there is no way to
have a tmp_path in DIRS of a django template engine.
@tony tony merged commit d3c7fce into master Nov 18, 2023
5 checks passed
@tony tony deleted the more-tests branch November 18, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant